adrian-prantl wrote:

> Please don't force-push in LLVM project, it makes it really hard to check if 
> feedback was addressed (I know this is not followed in the swift fork...)
> 
> https://llvm.org/docs/GitHub.html#rebasing-pull-requests-and-force-pushes
> 
> > avoid rebasing a Pull Request and force pushing to the branch that’s the 
> > root of the Pull Request during the review. This action will make the 
> > context of the old changes and comments harder to find and read

I wish I had read this first, not last!

https://github.com/llvm/llvm-project/pull/216389
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to