================
@@ -24,7 +24,7 @@ class CPlusPlusLanguage : public Language {
 public:
   class CxxMethodName : public Language::MethodName {
   public:
-    CxxMethodName(ConstString s) : Language::MethodName(s) {}
+    CxxMethodName(std::string s) : Language::MethodName(s) {}
----------------
qiyao wrote:

It copies `s` again when forwarding to the base constructor, so this should be 
`Language::MethodName(std::move(s))` to avoid the extra allocation/copy on 
every `CxxMethodName` construction.

https://github.com/llvm/llvm-project/pull/218556
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to