================
@@ -24,7 +24,7 @@ class CPlusPlusLanguage : public Language {
 public:
   class CxxMethodName : public Language::MethodName {
   public:
-    CxxMethodName(ConstString s) : Language::MethodName(s) {}
+    CxxMethodName(std::string s) : Language::MethodName(s) {}
----------------
felipepiovezan wrote:

If this code is hot, I think we should have both `const string &` and `string 
&&` overloads. For example, this:

```
      CxxMethodName cxx_method(demangled_name.GetStringRef().str());
```

Is still creating an extra copy, even with Yao's suggestion.

https://github.com/llvm/llvm-project/pull/218556
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to