labath added inline comments.
================
Comment at: packages/Python/lldbsuite/test/lldbinline.py:96-98
+ return "-N dwarf %s" % (testdir)
else:
+ return "-N dsym %s" % (testdir)
----------------
aprantl wrote:
> labath wrote:
> > xiaobai wrote:
> > > Good opportunity to move away from the old style of formatting strings to
> > > a newer style? It doesn't make a huge difference, I just think it'd be
> > > nice to do. :)
> > > `return "-N dwarf {}".format(testdir)`
> > > `return "-N dwarf {}".format(testdir)`
> > >
> > > This is supported in Python 2.7, but I'm not sure if we can assume that
> > > version or greater to be present.
> > 2.7 is definitely fine, and we use `{}` format in plently of places
> > already. (But I don't have any beef with the %s format either).
> In this case I think this should just be `return "-N dsym " + testdir`
:D
================
Comment at:
packages/Python/lldbsuite/test/python_api/hello_world/TestHelloWorld.py:85
"""Create target, spawn a process, and attach to it with process id."""
- self.build(dictionary=self.d)
- self.setTearDownCleanup(dictionary=self.d)
- target = self.dbg.CreateTarget(self.exe)
+ exe = self.getBuildArtifact(self.testMethodName)
+ d = {'EXE': exe}
----------------
I think `self.testMethodName` is what you're looking for. (There also seems to
be a `self._testMethodName` but I'm not sure what's the difference between the
two.)
https://reviews.llvm.org/D42763
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
