jingham added a comment.

Oh, somehow my browser hadn't updated to show the lit test.  Ignore the 
previous comment.

This is fine, except can you make the test check not depend on the particular 
result variable number ($0, $1, $2).  You aren't testing here that the result 
variable numbers are monotonically increasing integers that start at zero, and 
it will make adding to the test annoying over time.  This command output type 
of test is fragile because it depends on irrelevant details of command output.  
For instance TestCallStopAndContinue.test knows that the text we output for a 
stop is exactly "Execution was interrupted, reason: breakpoint" seems like more 
detail than a test should rely on.  Similarly the exact format of the result 
variable seems more detail than this test needs.


lldb-commits mailing list

Reply via email to