On 23 February 2018 at 11:24, Jim Ingham <jing...@apple.com> wrote: > To be fair, you could probably have made the dotest.py version of the test > close to as fast by not running a process. The old test was testing that we > got a location for the breakpoint AND hit it. The latter was probably > overkill. But the two tests aren't testing the same thing. >
Yes, they are not testing the same thing. However, my thought was (and it sounds like you agree) that for checking case-sensitivity checking we are able to resolve the breakpoint to a file address is enough. We have plenty of tests that verify the path from a file address to an actual breakpoint hit. The reason I went this route (instead of just modifying the original test) is that this will make it easy to write more low level breakpoint tests. For example, you can write an assembly file with amusing .loc directives and check that lldb resolves that reasonably (this looks like it could be useful for the ppc patch). Adding llvm-mc support to dotest.py would be possible, but more difficult than with a test like this. _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
