davide added subscribers: jasonmolenda, davide.
davide requested changes to this revision.
davide added a comment.
This revision now requires changes to proceed.
This requires an unittest (or an lldb-test test). Some comments inline.
I think @clayborg or @jasonmolenda are in a better position to review the
structure, I can take a look at the ELF specific details.
================
Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:1890-1891
// http://gcc.gnu.org/wiki/DwarfSeparateTypeInfo
- else if (name == g_sect_name_dwarf_debug_abbrev)
+ else if (name == g_sect_name_dwarf_debug_abbrev ||
+ name == g_sect_name_dwarf_zdebug_abbrev)
sect_type = eSectionTypeDWARFDebugAbbrev;
----------------
this whole cascade is really not ideal. Maybe we should factor the checks out
or move this to be a switch?
================
Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:2113-2115
+ // GOOGLE3: never use hash<char*> or hash<const char*>.
+#if 0
+
----------------
Please remove references to GOOGLE3.
Repository:
rL LLVM
https://reviews.llvm.org/D45628
_______________________________________________
lldb-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
