davide added inline comments.

================
Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:1773-1781
+static SectionType getSectionType(llvm::StringRef section_name) {
+  llvm::StringRef mapped_name;
+  if (section_name.startswith(".zdebug")) {
+    mapped_name = section_name.drop_front(2);
+  } else if (!section_name.startswith(".")) {
+    return eSectionTypeOther;
+  } else {
----------------
Thanks! This was exactly what I had in mind. Do you mind to split the NFC 
changes into a separate patch (that can be committed without review)? This will 
make this patch much easier to review.


https://reviews.llvm.org/D45628



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to