compnerd added inline comments.

Comment at: CMakeLists.txt:145
+  add_dependencies(lldb-suite lldb-framework)
Shouldn't this be `else()`?

Comment at: CMakeLists.txt:176
+      # The target to install libLLDB needs to depend on finish swig so that 
+      # framework build properly copies over the Python files.
"finish swig"?

Comment at: cmake/modules/LLDBFramework.cmake:5
+file(GLOB root_public_headers ${LLDB_SOURCE_DIR}/include/lldb/lldb-*.h)
+file(GLOB root_private_headers 
+list(REMOVE_ITEM root_public_headers ${root_private_headers})
Globs are generally frowned upon for dependency tracking issues.

lldb-commits mailing list

Reply via email to