shafik added a comment. +1 for modernizing code!
================ Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2262 + // assertion in the call to clang_type.TransferBaseClasses() + for (auto &base_class : bases) { clang::TypeSourceInfo *type_source_info = ---------------- `const auto &` ================ Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:3274 + if (!result) + break; + ---------------- Is this correct? the if/else below does not seem dependent on this result? https://reviews.llvm.org/D53590 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits