zturner added inline comments.

================
Comment at: 
lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:3273-3274
+                  is_virtual, is_base_of_class);
+          if (!result)
+            break;
+
----------------
If the result is a `nullptr`, then there is no base to begin with.  This 
indicates an error, so continuing doesn't make sense.  In fact, I think this 
was a bug with the previous implementation.  We were pushing back a null base 
onto the list of base classes.  I suspect it never actually happened in 
practice, though.


https://reviews.llvm.org/D53590



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to