labath marked 2 inline comments as done.
labath added inline comments.
================
Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp:706-713
- case DW_AT_ranges: {
- lldb::offset_t ranges_offset =
- GetRangesOffset(dwarf2Data->DebugRanges(), form_value);
- dw_addr_t base_addr = cu ? cu->GetBaseAddress() : 0;
- DWARFDebugRanges::Dump(s, dwarf2Data->get_debug_ranges_data(),
- &ranges_offset, base_addr);
- } break;
----------------
This is dead dumping code, which wasn't even correct for DWARF5.
================
Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3240-3260
- if (form_value.Form() == DW_FORM_sec_offset) {
- DWARFRangeList dwarf_scope_ranges;
- const DWARFDebugRangesBase *debug_ranges = DebugRanges();
- debug_ranges->FindRanges(die.GetCU(),
- form_value.Unsigned(),
- dwarf_scope_ranges);
- } else {
----------------
This is also effectively dead, as `scope_ranges` is not being initialized with
anything. Furthermore, I can find no evidence of clang ever emitting the
DW_AT_start_scope attribute.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62302/new/
https://reviews.llvm.org/D62302
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
