JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land.
Thanks! This LGTM with the comment on line 2660 rephrased and the motivation as part of the summary/commit message. ================ Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:2660 + // The symtab section is non-allocable and can be stripped. If both, .symtab + // and .dynsym exist, we load both. And if only .dymsym exists, we load it ---------------- > The symtab section is non-allocable and can be stripped, while the dynsym > section which should always be always be there. If both exist we load both to > support the minidebuginfo case. Otherwise we just load the dynsym section. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67390/new/ https://reviews.llvm.org/D67390 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
