teemperor marked 11 inline comments as done.
teemperor added inline comments.
================
Comment at: clang/lib/AST/DeclBase.cpp:95
DeclContext *Parent, std::size_t Extra) {
+ if (!(!Parent || &Parent->getParentASTContext() == &Ctx)) {
+ llvm::errs() << Parent << " | " << &Parent->getParentASTContext()
----------------
martong wrote:
> Left over debug printout?
Whoops, thanks.
================
Comment at:
lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.cpp:183
-namespace {
-/// This class walks an AST and ensures that all DeclContexts defined inside
the
----------------
shafik wrote:
> So we are removing this b/c we are now doing a minimal import from the
> temporary source and then in the next patch you will change that?
We always did a minimal import here and the completer just tried to turn this a
non-minimal import by iterating over the AST and then copying a bunch of
declarations over. It currently only seems to cause errors in the existing
tests. Also, we anyway don't test the feature it's actually supposed to
implement anywhere in LLLDB as this is a bug in the original LLDB. So this just
removes this code until we can properly implement and test it (which will
hopefully just be turning off the MinimalImport when importing from temporary
sources).
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68326/new/
https://reviews.llvm.org/D68326
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
