friss added inline comments.
================ Comment at: lldb/packages/Python/lldbsuite/test/make/Makefile.rules:316 -# Use a shared module cache when building in the default test build directory. -CLANG_MODULE_CACHE_DIR := $(shell echo "$(BUILDDIR)" | sed $(QUOTE)s/lldb-test-build.noindex.*/lldb-test-build.noindex\/module-cache-clang/$(QUOTE)) ---------------- labath wrote: > JDevlieghere wrote: > > We should have a fallback here that defaults to `$(BUILDDIR)/module-cache` > > if the variable is not set in the environment. > Is that wise, given D68731 tries to move away from autodetecting stuff in > `make`? > > What I think would be more useful is to pass this variable via the command > like instead of the environment. That way it will be visible in the `make` > invocation that dotest prints and the exact make invocation can be reproduced > by copy-pasting. It shouldn't be even hard to do that -- you'd just need > builder_base.py to fetch this from the `configuration` object and inject it > into the make arguments. +1 We shouldn't pass anything in the environment, it makes reproducing build failures a pain. (other variables I think are in the same bucket: DSYMUTIL and SDKROOT) Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68755/new/ https://reviews.llvm.org/D68755 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
