labath added inline comments.
================ Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:440 + + os.environ['CLANG_MODULE_CACHE_DIR'] = configuration.clang_module_cache_dir ---------------- So, what's the reason for passing this around through environment? Couldn't the "builder" module just fetch that from the configuration object? Using the environment to communicate between two python functions is just wrong... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68755/new/ https://reviews.llvm.org/D68755 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
