labath added a comment.

🍾



================
Comment at: 
lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:655
+  auto new_file = PythonFile::FromFile(file, mode);
+  if (!new_file)
+    return false;
----------------
You'll need to handle the error here. (And it would be better to replace auto 
with Expected<PythonFile> as that would make it obvious that the error needs to 
be handled.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68963/new/

https://reviews.llvm.org/D68963



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to