lawrence_danna marked an inline comment as done. lawrence_danna added inline comments.
================ Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:655 + auto new_file = PythonFile::FromFile(file, mode); + if (!new_file) + return false; ---------------- labath wrote: > You'll need to handle the error here. (And it would be better to replace auto > with Expected<PythonFile> as that would make it obvious that the error needs > to be handled.) thanks, I don't know why I can't remember to do that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68963/new/ https://reviews.llvm.org/D68963 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
