stella.stamenova added a comment.

This change looks fine assuming all the tests continue to pass.

I think it makes sense to update the script to allow more arguments and/or 
invoke clang-cl directly instead of using the script. I suspect that using 
clang-cl directly will not work though - the script does a lot of the setup 
needed to run clang-cl correctly today (previously the environment for clang-cl 
was not setup correctly and the tests either didn't pass or passed for the 
wrong reasons, so using build.py has been a huge improvement).


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68980/new/

https://reviews.llvm.org/D68980



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to