shafik added inline comments.
================
Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:1318
+
+static llvm::VersionTuple ParseSDKVersion(llvm::StringRef &name) {
+ unsigned i = 0;
----------------
We should document what we expect the format to be. I mean I can deduce it from
the code but I would prefer to have it spelled out and then check the code
parses the expected format correctly.
================
Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:1336
+
+std::tuple<int, llvm::VersionTuple> SDK::Parse() const {
+ llvm::StringRef input = m_name.GetStringRef();
----------------
We should have tests for this and the rest of the methods here.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76471/new/
https://reviews.llvm.org/D76471
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
