mib marked 3 inline comments as done. mib added inline comments.
================ Comment at: lldb/source/Core/ValueObject.cpp:665 bool child_is_deref_of_parent = false; + CompilerType compiler_type = GetCompilerType(); uint64_t language_flags = 0; ---------------- teemperor wrote: > This change (and the one below) don't seem to be some NFC refactoring? Not > sure why this was refactored as `compiler_type` is only ever used once where > we previously called `GetCompilerType()`? This is a remaining from a previous change that I ended up not removing. I'll change it back the way it was. ================ Comment at: lldb/test/API/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjCNSContainer.py:59-60 + + self.expect( + 'frame variable -d run-target *cfDictionaryRef', + patterns=[ ---------------- friss wrote: > I must be missing something obvious, but it seems like that patch doesn't > register a formatter for CFDictionaryRef. Was it already there but > non-functional? The string summary worked but not the synthetic child provider. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79554/new/ https://reviews.llvm.org/D79554 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
