jingham added inline comments.
================
Comment at: lldb/source/Core/ValueObject.cpp:2846
+ if (llvm::isa<TypeSystemClang>(compiler_type.GetTypeSystem())) {
+ if (HasSyntheticValue()) {
+ TargetSP target_sp = GetTargetSP();
----------------
mib wrote:
> friss wrote:
> > I am understanding correctly that this condition will only trigger when
> > there's a synthetic child provider for the type? In other words, if we have
> > an opaque pointer that we don't know how to display, it will still cause an
> > error, right?
> Yes, from my understanding, if the opaque pointer doesn't have any synthetic
> child provider, it won't have a synthetic value and lldb should error saying
> `error: dereference failed`.
We should add a test to make sure this stays true.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79554/new/
https://reviews.llvm.org/D79554
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
