shafik added inline comments.
================
Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:5215
+ uint32_t num_pointee_children = 0;
+ if (pointee_clang_type.IsAggregateType())
+ num_pointee_children =
----------------
I am curious what cases are pointers aggregates? Do we test this case?
================
Comment at:
lldb/test/API/functionalities/pointer_num_children/TestPointerNumChildren.py:20
+ self.assertEqual("42",
result.GetChildAtIndex(0).GetChildAtIndex(0).GetValue())
+ self.assertEqual(1, result.GetNumChildren())
+
----------------
We should also check
```
result.GetChildAtIndex(0).GetNumChildren()
```
same below
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80254/new/
https://reviews.llvm.org/D80254
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
