jingham added a comment. The change makes sense.
If I run lldb on a binary, hit a breakpoint, run to it, then change a file, rebuild the executable outside lldb and rerun, I only see one instance of the executable. Why does that path not need your fix? ================ Comment at: lldb/include/lldb/Core/ModuleList.h:142 /// A shared pointer to a module to replace in this collection. - void ReplaceEquivalent(const lldb::ModuleSP &module_sp); + void ReplaceEquivalent( + const lldb::ModuleSP &module_sp, ---------------- You added another parameter, so you should add it to the docs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89157/new/ https://reviews.llvm.org/D89157 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
