JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: lldb/source/Utility/Args.cpp:178
+Args::Args(llvm::ArrayRef<llvm::StringRef> args) : Args() {
+ for (llvm::StringRef arg : args)
----------------
labath wrote:
> JDevlieghere wrote:
> > Maybe StringList should have a ctor that takes an `ArrayRef<StringRef>`,
> > but probably not worth the extra copies here.
> I think it can have that constructor if it's needed (though I'd rather delete
> that class altogether), but I think this constructor would be good to have
> regardless.
Agreed on both accounts
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89477/new/
https://reviews.llvm.org/D89477
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
