Thanks! Done. On Sat, 17 Oct 2020 at 12:45, Galina Kistanova <gkistan...@gmail.com> wrote:
> Thanks everyone for keeping your annotated builders in the staging area! > Much appreciated. > > Please feel free to move all the green builders back to the production. It > has a new AnnotatedCommand now. > > Thanks > > Galina > > > On Thu, Oct 15, 2020 at 12:46 AM Vitaly Buka <vitalyb...@google.com> > wrote: > >> Ok, I can switch them back to staging. However today's staging was >> frequently offline. >> >> >> On Wed, 14 Oct 2020 at 21:44, Galina Kistanova <gkistan...@gmail.com> >> wrote: >> >>> Thanks everyone! >>> >>> I would like to keep the bots in the staging till Friday. And if >>> everything is good, then apply the changes to the production and let you >>> move all the green bots back there. >>> >>> Thanks >>> >>> Galina >>> >>> >>> On Tue, Oct 13, 2020 at 10:43 PM Vitaly Buka <vitalyb...@google.com> >>> wrote: >>> >>>> They do on staging. >>>> http://lab.llvm.org:8014/#/builders/sanitizer-windows >>>> http://lab.llvm.org:8014/#/builders/clang-x64-windows-msvc >>>> >>>> Galina, when do you plan to push this to the primary server? >>>> If it's a few days, I'd rather keep bots on staging to have colors. >>>> >>>> >>>> >>>> On Tue, 13 Oct 2020 at 11:11, Reid Kleckner <r...@google.com> wrote: >>>> >>>>> FWIW, I don't see any issues with my two bots that use buildbot >>>>> annotated commands: >>>>> http://lab.llvm.org:8011/#/builders/sanitizer-windows >>>>> http://lab.llvm.org:8011/#/builders/clang-x64-windows-msvc >>>>> The individual steps don't highlight as green or red, but that's OK >>>>> for now. >>>>> >>>>> On Mon, Oct 12, 2020 at 7:19 PM Galina Kistanova <gkistan...@gmail.com> >>>>> wrote: >>>>> >>>>>> We have a better version of AnnotatedCommand on the staging. It >>>>>> should be a functional equivalent of the old one. >>>>>> We need to stress test it well before moving to the production build >>>>>> bot. >>>>>> >>>>>> For that we need all sanitizer + other bots which use the >>>>>> AnnotatedCommand directly or indirectly moved temporarily to the staging. >>>>>> >>>>>> Please let me know when that could be arranged. >>>>>> >>>>>> Thanks >>>>>> >>>>>> Galina >>>>>> >>>>>> On Mon, Oct 12, 2020 at 11:39 AM Reid Kleckner <r...@google.com> >>>>>> wrote: >>>>>> >>>>>>> On Wed, Oct 7, 2020 at 4:32 PM Galina Kistanova via lldb-commits < >>>>>>> lldb-commits@lists.llvm.org> wrote: >>>>>>> >>>>>>>> They are online now - >>>>>>>> http://lab.llvm.org:8011/#/waterfall?tags=sanitizer >>>>>>>> >>>>>>>> AnnotatedCommand has severe design conflict with the new buildbot. >>>>>>>> We have changed it to be safe and still do something useful, but it >>>>>>>> will need more love and care. >>>>>>>> >>>>>>>> Please let me know if you have some spare time to work on porting >>>>>>>> AnnotatedCommand. >>>>>>>> >>>>>>> >>>>>>> That's unfortunate, it would've been good to know that earlier. I >>>>>>> and another team member have spent a fair amount of time porting things >>>>>>> to >>>>>>> use more AnnotatedCommand steps, because it gives us the flexibility to >>>>>>> test steps locally and make changes to the steps without restarting the >>>>>>> buildbot master. IMO that is the Right Way to define steps: a script >>>>>>> that >>>>>>> you can run locally on a machine that satisfies the OS and dep >>>>>>> requirements >>>>>>> of the script. >>>>>>> >>>>>>> I am restarting the two bots that I am responsible for, and may need >>>>>>> some help debugging further issues soon. I'll let you know. >>>>>>> >>>>>>
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits