mgorny created this revision.
mgorny added reviewers: labath, JDevlieghere, zturner, krytarowski, emaste.
mgorny requested review of this revision.

Use skipUnlessDarwin decorator for tests that are specific to Darwin,
instead of skipIf... for all other platforms.  This should make it clear
that these tests are not supposed to work elsewhere.  It will also make
these tests stop repeatedly popping up while I look for tests that could
be fixed on the platform in question.


https://reviews.llvm.org/D91003

Files:
  
lldb/test/API/functionalities/data-formatter/setvaluefromcstring/TestSetValueFromCString.py
  lldb/test/API/lang/objc/objc-foundation-dictionary-empty/TestNSDictionary0.py
  lldb/test/API/lang/objc/objc-ivar-protocols/TestIvarProtocols.py
  lldb/test/API/lang/objc/objc-runtime-ivars/TestRuntimeIvars.py
  lldb/test/API/lang/objc/variadic_methods/TestVariadicMethods.py
  lldb/test/API/lang/objcxx/class-name-clash/TestNameClash.py
  lldb/test/API/lang/objcxx/hide-runtime-values/TestObjCXXHideRuntimeValues.py
  lldb/test/API/lang/objcxx/objcxx-ivar-vector/TestIvarVector.py
  lldb/test/API/python_api/exprpath_synthetic/TestExprPathSynthetic.py
  lldb/test/API/python_api/sbtype_typeclass/TestSBTypeTypeClass.py

Index: lldb/test/API/python_api/sbtype_typeclass/TestSBTypeTypeClass.py
===================================================================
--- lldb/test/API/python_api/sbtype_typeclass/TestSBTypeTypeClass.py
+++ lldb/test/API/python_api/sbtype_typeclass/TestSBTypeTypeClass.py
@@ -3,8 +3,7 @@
 
 lldbinline.MakeInlineTest(
     __file__, globals(), [
-        decorators.skipIfFreeBSD, decorators.skipIfLinux,
-        decorators.skipIfWindows, decorators.skipIfNetBSD,
+        decorators.skipUnlessDarwin,
         decorators.expectedFailureAll(
             oslist=['macosx'], archs=['i386'],
             bugnumber='rdar://28656677')])
Index: lldb/test/API/python_api/exprpath_synthetic/TestExprPathSynthetic.py
===================================================================
--- lldb/test/API/python_api/exprpath_synthetic/TestExprPathSynthetic.py
+++ lldb/test/API/python_api/exprpath_synthetic/TestExprPathSynthetic.py
@@ -2,6 +2,4 @@
 from lldbsuite.test import lldbinline
 
 lldbinline.MakeInlineTest(
-    __file__, globals(), [
-        decorators.skipIfFreeBSD, decorators.skipIfLinux,
-        decorators.skipIfWindows, decorators.skipIfNetBSD])
+    __file__, globals(), [decorators.skipUnlessDarwin])
Index: lldb/test/API/lang/objcxx/objcxx-ivar-vector/TestIvarVector.py
===================================================================
--- lldb/test/API/lang/objcxx/objcxx-ivar-vector/TestIvarVector.py
+++ lldb/test/API/lang/objcxx/objcxx-ivar-vector/TestIvarVector.py
@@ -2,6 +2,4 @@
 from lldbsuite.test import lldbinline
 
 lldbinline.MakeInlineTest(
-    __file__, globals(), [
-        decorators.skipIfFreeBSD, decorators.skipIfLinux,
-        decorators.skipIfWindows, decorators.skipIfNetBSD])
+    __file__, globals(), [decorators.skipUnlessDarwin])
Index: lldb/test/API/lang/objcxx/hide-runtime-values/TestObjCXXHideRuntimeValues.py
===================================================================
--- lldb/test/API/lang/objcxx/hide-runtime-values/TestObjCXXHideRuntimeValues.py
+++ lldb/test/API/lang/objcxx/hide-runtime-values/TestObjCXXHideRuntimeValues.py
@@ -9,10 +9,7 @@
 
     mydir = TestBase.compute_mydir(__file__)
 
-    @skipIfFreeBSD
-    @skipIfLinux
-    @skipIfWindows
-    @skipIfNetBSD
+    @skipUnlessDarwin
     def test_hide_runtime_support_values(self):
         self.build()
         _, process, _, _ = lldbutil.run_to_source_breakpoint(
Index: lldb/test/API/lang/objcxx/class-name-clash/TestNameClash.py
===================================================================
--- lldb/test/API/lang/objcxx/class-name-clash/TestNameClash.py
+++ lldb/test/API/lang/objcxx/class-name-clash/TestNameClash.py
@@ -2,6 +2,4 @@
 from lldbsuite.test import lldbinline
 
 lldbinline.MakeInlineTest(
-    __file__, globals(), [
-        decorators.skipIfFreeBSD, decorators.skipIfLinux,
-        decorators.skipIfWindows, decorators.skipIfNetBSD])
+    __file__, globals(), [decorators.skipUnlessDarwin])
Index: lldb/test/API/lang/objc/variadic_methods/TestVariadicMethods.py
===================================================================
--- lldb/test/API/lang/objc/variadic_methods/TestVariadicMethods.py
+++ lldb/test/API/lang/objc/variadic_methods/TestVariadicMethods.py
@@ -2,6 +2,4 @@
 from lldbsuite.test import decorators
 
 lldbinline.MakeInlineTest(
-    __file__, globals(), [
-        decorators.skipIfFreeBSD, decorators.skipIfLinux,
-        decorators.skipIfWindows, decorators.skipIfNetBSD])
+    __file__, globals(), [decorators.skipUnlessDarwin])
Index: lldb/test/API/lang/objc/objc-runtime-ivars/TestRuntimeIvars.py
===================================================================
--- lldb/test/API/lang/objc/objc-runtime-ivars/TestRuntimeIvars.py
+++ lldb/test/API/lang/objc/objc-runtime-ivars/TestRuntimeIvars.py
@@ -3,6 +3,5 @@
 
 lldbinline.MakeInlineTest(
     __file__, globals(), [
-        decorators.skipIfFreeBSD, decorators.skipIfLinux,
-        decorators.skipIfWindows, decorators.skipIfNetBSD,
+        decorators.skipUnlessDarwin,
         decorators.skipIf(archs=["i386", "i686"])])
Index: lldb/test/API/lang/objc/objc-ivar-protocols/TestIvarProtocols.py
===================================================================
--- lldb/test/API/lang/objc/objc-ivar-protocols/TestIvarProtocols.py
+++ lldb/test/API/lang/objc/objc-ivar-protocols/TestIvarProtocols.py
@@ -2,6 +2,4 @@
 from lldbsuite.test import decorators
 
 lldbinline.MakeInlineTest(
-    __file__, globals(), [
-        decorators.skipIfFreeBSD, decorators.skipIfLinux,
-        decorators.skipIfWindows, decorators.skipIfNetBSD])
+    __file__, globals(), [decorators.skipUnlessDarwin])
Index: lldb/test/API/lang/objc/objc-foundation-dictionary-empty/TestNSDictionary0.py
===================================================================
--- lldb/test/API/lang/objc/objc-foundation-dictionary-empty/TestNSDictionary0.py
+++ lldb/test/API/lang/objc/objc-foundation-dictionary-empty/TestNSDictionary0.py
@@ -2,6 +2,4 @@
 from lldbsuite.test import decorators
 
 lldbinline.MakeInlineTest(
-    __file__, globals(), [
-        decorators.skipIfFreeBSD, decorators.skipIfLinux,
-        decorators.skipIfWindows, decorators.skipIfNetBSD])
+    __file__, globals(), [decorators.skipUnlessDarwin])
Index: lldb/test/API/functionalities/data-formatter/setvaluefromcstring/TestSetValueFromCString.py
===================================================================
--- lldb/test/API/functionalities/data-formatter/setvaluefromcstring/TestSetValueFromCString.py
+++ lldb/test/API/functionalities/data-formatter/setvaluefromcstring/TestSetValueFromCString.py
@@ -2,6 +2,4 @@
 from lldbsuite.test import decorators
 
 lldbinline.MakeInlineTest(
-    __file__, globals(), [
-        decorators.skipIfFreeBSD, decorators.skipIfLinux,
-        decorators.skipIfNetBSD, decorators.skipIfWindows])
+    __file__, globals(), [decorators.skipUnlessDarwin])
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to