pcc added inline comments.
================ Comment at: lldb/source/Target/Process.cpp:5569-5570 + + if (m_code_address_mask == 0) + return -1; // All bits are used for addressing. + ---------------- Is this part correct? (Same below.) In D100521 you have ``` if (pc & pac_sign_extension) return pc | mask; return pc & (~mask); ``` So it looks like this would cause the pc to be set to 0 (or -1)? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100515/new/ https://reviews.llvm.org/D100515 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits