wallace marked 9 inline comments as done. wallace added inline comments.
================ Comment at: lldb/include/lldb/Target/Target.h:1137-1141 + llvm::Expected<lldb::TraceSP &> CreateTrace(); + + /// If a \a Trace object is present, this returns it, otherwise a new Trace is + /// created with \a Trace::CreateTrace. llvm::Expected<lldb::TraceSP &> GetTraceOrCreate(); ---------------- clayborg wrote: > Do we need both of these? GetTraceOrCreate is quite handy for the CommandObjects. And CreateTrace seems more correct from the SB API side, so I'd like to keep them there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103500/new/ https://reviews.llvm.org/D103500 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
