JDevlieghere added inline comments.
================
Comment at: lldb/bindings/interface/SBTrace.i:32-51
+ /// deprecated
void StopTrace(SBError &error,
lldb::tid_t thread_id);
+ /// deprecated
void GetTraceConfig(SBTraceOptions &options,
SBError &error);
----------------
Do you have clients that already rely on these functions? Writing deprecated
above them means nothing. When I was doing the reproducers, I included a
warning in the header saying that this was under development and the API wasn't
final, which allowed me to iterate on it. Can we just remove these methods and
to the same here?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103500/new/
https://reviews.llvm.org/D103500
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
