labath added a comment. In D111964#3071292 <https://reviews.llvm.org/D111964#3071292>, @mgorny wrote:
> In D111964#3069414 <https://reviews.llvm.org/D111964#3069414>, @labath wrote: > >> What's the test strategy for this? > > Still thinking about it. I'm mostly PoC-ing this while other changes are > waiting. For the current patch, I guess it would be sufficient to establish a connection using _any_ url. ================ Comment at: lldb/tools/lldb-server/lldb-gdbserver.cpp:237-249 + if (!is_url) { + // Ensure we have a port number for the connection. + // Note: use rfind, because the host/port may look like "[::1]:12345". + uint32_t connection_portno = 0; + const std::string::size_type colon_pos = final_host_and_port.rfind(':'); + if (colon_pos != std::string::npos) + llvm::to_integer(final_host_and_port.substr(colon_pos + 1), ---------------- I am wondering what's the impact of removing this. If we get some semi-reasonable message, then it'd be nice to get rid of it. Otherwise, we'll have a weird difference between the user typing `host:0` and `connect://host:0`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111964/new/ https://reviews.llvm.org/D111964 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
