labath added inline comments.
================
Comment at: lldb/tools/lldb-server/lldb-gdbserver.cpp:237-249
+ if (!is_url) {
+ // Ensure we have a port number for the connection.
+ // Note: use rfind, because the host/port may look like "[::1]:12345".
+ uint32_t connection_portno = 0;
+ const std::string::size_type colon_pos =
final_host_and_port.rfind(':');
+ if (colon_pos != std::string::npos)
+ llvm::to_integer(final_host_and_port.substr(colon_pos + 1),
----------------
labath wrote:
> I am wondering what's the impact of removing this. If we get some
> semi-reasonable message, then it'd be nice to get rid of it. Otherwise, we'll
> have a weird difference between the user typing `host:0` and
> `connect://host:0`.
If we don't get a reasonable error message, we could probably create one by
pushing this check into the lower layers.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111964/new/
https://reviews.llvm.org/D111964
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
