wallace requested changes to this revision. wallace added inline comments. This revision now requires changes to proceed.
================ Comment at: lldb/source/Breakpoint/Breakpoint.cpp:1120 + else + llvm::consumeError(expected_value.takeError()); + } ---------------- err, i'm not a fan of this. Why don't you just make this return an expected and make the main command fail if the data couldn't be gathered? That will be better than concealing some possible parsing issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112587/new/ https://reviews.llvm.org/D112587 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
