clayborg added inline comments.
================ Comment at: lldb/source/Breakpoint/Breakpoint.cpp:1120 + else + llvm::consumeError(expected_value.takeError()); + } ---------------- wallace wrote: > err, i'm not a fan of this. Why don't you just make this return an expected > and make the main command fail if the data couldn't be gathered? That will be > better than concealing some possible parsing issues. How about I put the error string into the "details" as a key/value pair if this has an error? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112587/new/ https://reviews.llvm.org/D112587 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
