llunak abandoned this revision. llunak added a comment. In D123020#3426867 <https://reviews.llvm.org/D123020#3426867>, @JDevlieghere wrote:
> FWIW the official policy is outlined here: > https://llvm.org/docs/CodeReview.html I'm aware of it, but as far as I can judge I was following it. Even reading it now again I see nothing that I would understand as mandating review for everything. > The GDB remote packet timeout is customizable: > ... > So maybe we don't need this patch? The timeout in GDBRemoteCommunicationClient::QueryNoAckModeSupported() is hardcoded to 6 seconds, so I doubt the setting matters there. And even if it did, I'd find it sometwhat silly having to look for a please-unbreak-valgrind setting, especially given that there is already LLVM support for detecting Valgrind. But this all is too much for something so simple. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123020/new/ https://reviews.llvm.org/D123020 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
