aprantl added a comment. In D134344#3805953 <https://reviews.llvm.org/D134344#3805953>, @Michael137 wrote:
>> teach the debug info replication to ignore tests with the gmodules category >> (just like it does for @no_debug_info_test_case tests). This step wouldn't >> be necessary if we made debug info replication opt-in instead of opt-out, as >> discussed on one of the previous patches (@JDevlieghere might remember which >> one it was) > > That's an interesting idea. @JDevlieghere @aprantl How much appetite is there > for changing the replication to be opt-in (that would require an audit of > each API test right?). Otherwise, an alternative that comes to mind without > hard-coding a `category == gmodules` into the replication logic would be to > make `debug_info_categories` a `dictionary<category: string, replicable: > bool>` and keep `gmodules` in there. Then we wouldn't need to make changes to > `getBuildCommand` either. That's such a big change (we also need to make the change in all downstream branches like swift-lldb) that I probably wouldn't want to roll it into this patch series right now, but I'm open to having a separate discussion about it. But I'm also missing the context as to why this would be desirable, so if there's a good reason, let me know! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134344/new/ https://reviews.llvm.org/D134344 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
