zequanwu created this revision.
zequanwu added a reviewer: labath.
Herald added a project: All.
zequanwu requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
Minidump may contain modules that are created from placeholder object files if
they are not loaded. Add a `(placeholder)` suffix to indicate they are not
loaded, which is more clear than checking if the address is 0x0 in
`target module list -o`.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D136795
Files:
lldb/source/Commands/CommandObjectTarget.cpp
Index: lldb/source/Commands/CommandObjectTarget.cpp
===================================================================
--- lldb/source/Commands/CommandObjectTarget.cpp
+++ lldb/source/Commands/CommandObjectTarget.cpp
@@ -3110,11 +3110,14 @@
DumpModuleArchitecture(strm, module, true, width);
break;
- case 'f':
+ case 'f': {
DumpFullpath(strm, &module->GetFileSpec(), width);
dump_object_name = true;
+ ObjectFile *objfile = module->GetObjectFile();
+ if (objfile && objfile->GetPluginName() == "placeholder")
+ strm.Printf(" (placeholder)");
break;
-
+ }
case 'd':
DumpDirectory(strm, &module->GetFileSpec(), width);
break;
Index: lldb/source/Commands/CommandObjectTarget.cpp
===================================================================
--- lldb/source/Commands/CommandObjectTarget.cpp
+++ lldb/source/Commands/CommandObjectTarget.cpp
@@ -3110,11 +3110,14 @@
DumpModuleArchitecture(strm, module, true, width);
break;
- case 'f':
+ case 'f': {
DumpFullpath(strm, &module->GetFileSpec(), width);
dump_object_name = true;
+ ObjectFile *objfile = module->GetObjectFile();
+ if (objfile && objfile->GetPluginName() == "placeholder")
+ strm.Printf(" (placeholder)");
break;
-
+ }
case 'd':
DumpDirectory(strm, &module->GetFileSpec(), width);
break;
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
