labath added a comment.

It's a good idea, but this is a pretty bad layering violation. The 
"placeholder" object files aren't even first class plugins (though I think they 
should be -- as the concept is useful in other situations as well), but an 
internal detail of the minidump process plugin.

Ideally, we would do this from inside the minidump code, perhaps by modifying 
the name (file spec) of the fake object file?

A test would be nice as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136795/new/

https://reviews.llvm.org/D136795

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to