aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land.
================ Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:1363 + XcodeSDK sdk; + for (unsigned i = 0; i < sym_file->GetNumCompileUnits(); ++i) + if (auto cu_sp = sym_file->GetCompileUnitAtIndex(i)) ---------------- Michael137 wrote: > Only remaining question is whether we want to limit this to just Objective-C > and Swift. Going through each compile unit for C++ seems like a lot of work > for something that we won't use > > @aprantl The work to detect the language and to get the SDK attribute is almost the same, both are stored in the top-level CU DIE. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156020/new/ https://reviews.llvm.org/D156020 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
