Looks safe to me and it is nice to clear up warnings when we can. On Jun 19, 2013, at 7:30 AM, Andy Gibbs <[email protected]> wrote:
> Hi, > > Does anyone have any objections to me committing this patch? > > Thanks > Andy > > > On Friday, June 14, 2013 5:14 PM, Andy Gibbs wrote: >> Hi, >> >> Following on from the recent discussion on build warnings at >> http://lists.cs.uiuc.edu/pipermail/lldb-dev/2013-June/001854.html et al., >> attached is a patch that sorts out a good number of those warnings. >> >> However... I don't have a working lldb build in any case -- this is what I >> am working towards -- so I am not able to check whether this patch >> introduces any regressions. I hope and believe not, but could someone else >> verify for me before I commit it? Mostly the patch is sorting out >> mismatched integer types. I've been very conservative, so there are still >> quite a few more warnings still being emitted, but it may still have cleared >> enough of the wood away to see the remaining trees :o) >> >> Thanks >> >> Andy >> > <lldb (1).diff>_______________________________________________ > lldb-dev mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev _______________________________________________ lldb-dev mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev
