I just checked the the MinGW patch was submitted with revision 189107. So you can now merge top of tree into the windows branch and start submitting patches.
A few things to keep in mind are that any windows (host specific) features need to be abstracted into the lldb_private::Host layer in a system agnostic interface. The files that implement the features should be in source/Host/windows. The only exceptions is in the .cpp files of plugins (like ConnectionFileDescriptor.cpp) where it is ok, in the .cpp file, to add windows specific function calls and logic. I look forward to seeing the upcoming patches and getting windows support into top of tree. Greg On Aug 23, 2013, at 9:28 AM, Greg Clayton <gclay...@apple.com> wrote: > > On Aug 23, 2013, at 9:03 AM, Colin Riley <co...@codeplay.com> wrote: > >> Hello all, Codeplay reporting in. >> >> We want to do the merge and unification between the windows and trunk >> branches of LLDB. We are doing lots of work with LLDB and it seems the most >> sensible thing do to given the amount of effort we currently undertake to >> maintain both branches locally. >> >> Obviously the merge must not break the buildbots currently running on the >> non-windows target. Additionally, the tests do not run at all under windows, >> which is an issue we will need to look into solving. It will be difficult >> given the fact the windows branch itself will not be able to actually debug >> on windows, however we'd like to do this to the point where the windows >> branch can be closed. >> >> Our questions to folk on here: what would be accepted in terms of support >> for this? It could be quite a large patch, and touch many areas, but it is >> something that needs done to further advance LLDB support for other >> architectures and platforms. It will also include changes to the driver so a >> command line frontend is available for windows. > > We currently have a MinGW patch that is in the process of trying to get > submitted, so I would hold off on any commits/patches until this makes it in. > The patch is currently causing deadlocks on linux buildbots. Once this is in, > we can then merge top of tree with the windows branch prior to submitting > patches for the final windows merge that will allow us to remove the windows > branch. > >> >> Are there any reservations folk have for this, and if so, can we overcome >> them? > > So first we need to get the MinGW patch submitted, then we can proceed. > > Greg > >> >> Many thanks, >> >> Colin >> (cc'd with Deepak, who is also involved with this) >> >> -- >> Colin Riley >> Games Technology Director >> >> Codeplay Software Ltd >> 45 York Place, Edinburgh, EH1 3HP >> Phone: +44 131 466 0503 >> Fax: +44 131 557 6600 >> Website: http://www.codeplay.com >> Twitter: @codeplaysoft >> >> This email and any attachments may contain confidential and /or privileged >> information and is for use by the addressee only. If you are not the >> intended recipient, please notify Codeplay Software Ltd immediately and >> delete the message from your computer. You may not copy or forward it,or use >> or disclose its contents to any other person. Any views or other information >> in this message which do not relate to our business are not authorized by >> Codeplay software Ltd, nor does this message form part of any contract >> unless so stated. >> As internet communications are capable of data corruption Codeplay Software >> Ltd does not accept any responsibility for any changes made to this message >> after it was sent. Please note that Codeplay Software Ltd does not accept >> any liability or responsibility for viruses and it is your responsibility to >> scan any attachments. >> Company registered in England and Wales, number: 04567874 >> Registered office: 81 Linkfield Street, Redhill RH1 6BY >> >> _______________________________________________ >> lldb-dev mailing list >> lldb-dev@cs.uiuc.edu >> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev > > _______________________________________________ > lldb-dev mailing list > lldb-dev@cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev _______________________________________________ lldb-dev mailing list lldb-dev@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev
