On Thu Nov 13 2014 at 10:34:04 AM <jing...@apple.com> wrote: > > I see nothing wrong with the content of that comment. It's clear that it > means "addr_size" was changed to mean something it shouldn't mean. The > details in the Radar are "addr_size no longer returns the correct value." > which was obvious from the fact that it's definition was changed and didn't > add any more detail. So saying more about it wouldn't have helped. >
Yea, I guess I'm just advocating for more detail in general. A few years from now, I'll even forget what problems my own commits were trying to solve, much less someone else's :)
_______________________________________________ lldb-dev mailing list lldb-dev@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev
