> > > +1 - the patch seemed trivial and obvious enough that a few words suffice > to explain it, regardless of radar >
I agree, and sorry for using your patch to bring the issue up. It's just something I've seen off and on through the months. I probably should have just raised the issue of more descriptive commit message independently of radar, so my fault on that front. Like an "even if there's nothing wrong, that doesn't mean it can't be improved" kind of thing. I usually try to write commit messages so that someone who doesn't understand anything about Windows can still figure out what my patch is doing. I was actually under the impression that other LLVM projects weren't allowed to put rdar numbers in commit messages, but someone explained to me offline that I was wrong about that, so putting it at the bottom is probably fine.
_______________________________________________ lldb-dev mailing list lldb-dev@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev
