Sounds like a reasonable thing to do. A couple of tiny remarks: - when you do the move, you might as well rename dotest into something else, just to avoid the "which dotest should I run" type of questions... - there is nothing that makes it obvious that "engine" is actually a "test running engine", as it sits in a sibling folder. OTOH, "test_engine" might be too verbose, and messes up tab completion, so that might not be a good idea either...
pl On 10 December 2015 at 23:30, Zachary Turner via lldb-dev <lldb-dev@lists.llvm.org> wrote: > Currently our folder structure looks like this: > > lldbsuite > |-- test > |-- dotest.py > |-- dosep.py > |-- lldbtest.py > |-- ... > |-- functionalities > |-- lang > |-- expression_command > |-- ... > etc > > I've been thinking about organizing it like this instead: > > lldbsuite > |-- test > |-- functionalities > |-- lang > |-- expression_command > |-- ... > |-- engine > |-- dotest.py > |-- dosep.py > |-- lldbtest.py > |-- ... > > Anybody have any thoughts on this? Good idea or bad idea? The main reason > I want to do this is because as we start breaking up some of the code, it > makes sense to start having some subpackages under the `engine` folder (or > the `test` folder in our current world). For example, Todd and I have > discussed the idea of putting formatter related stuff under a `formatters` > subpackage. In the current world, there's no way to differentiate between > folders which contain tests and folders which contain test infrastructure, > so when we walk the directory tree looking for tests we end up walking a > bunch of directories that are used for test infrastructure code and not > actual tests. So I like the logical separation this provides -- having the > tests themselves all under a single subpackage. > > Thoughts? > > _______________________________________________ > lldb-dev mailing list > lldb-dev@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev > _______________________________________________ lldb-dev mailing list lldb-dev@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev