================ @@ -936,8 +936,10 @@ void ClauseProcessor::processMapObjects( llvm::omp::OpenMPOffloadMappingFlags mapTypeBits, std::map<Object, OmpMapParentAndMemberData> &parentMemberIndices, llvm::SmallVectorImpl<mlir::Value> &mapVars, - llvm::SmallVectorImpl<const semantics::Symbol *> &mapSyms) const { + llvm::SmallVectorImpl<const semantics::Symbol *> &mapSyms, + std::string mapperIdName) const { ---------------- TIFitis wrote:
In this case, even we accept a `StringRef`, we would have to immediately copy it to a `std:string` as we need to pass an `lvalue` to `converter.mangleName`. As such, wouldn't it be better to accept it as a string. https://github.com/llvm/llvm-project/pull/121001 _______________________________________________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits