================
@@ -936,8 +936,10 @@ void ClauseProcessor::processMapObjects(
llvm::omp::OpenMPOffloadMappingFlags mapTypeBits,
std::map<Object, OmpMapParentAndMemberData> &parentMemberIndices,
llvm::SmallVectorImpl<mlir::Value> &mapVars,
- llvm::SmallVectorImpl<const semantics::Symbol *> &mapSyms) const {
+ llvm::SmallVectorImpl<const semantics::Symbol *> &mapSyms,
+ std::string mapperIdName) const {
----------------
skatrak wrote:
Accepting a `StringRef` gives us more flexibility while passing arguments
(plus, it gives us the option to rework the implementation to avoid copies
later on), it follows [LLVM
recommendations](https://llvm.org/docs/ProgrammersManual.html#passing-strings-the-stringref-and-twine-classes)
and I don't see any drawbacks from using it here. In my opinion, I still think
it's a better option. If you feel strongly about it, this is not a blocking
issue for me.
https://github.com/llvm/llvm-project/pull/121001
_______________________________________________
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
