OCHyams wrote:

> Possibly part of the design here is to simply not care, if it's only about 
> internal consistency within a Function (does that hold after inlining too). 
> Apologies if this is all explained in a later patch.

It is indeed the goal not to care; an instruction is only considered to be from 
the same source atom as another instruction (implied: in the same function) if 
they've got the same `atomGroup` and `inlinedAt` fields. (we only ever examine 
the groups within the context of a function, i.e., we don't ever try to ask 
"are these instructions in different functions from the same source atom").

> The answers to that should ultimately be documented somewhere; I imagine 
> that's in the patch stack or coming later.

Your imagination gives me too much credit. It's documented in some comments 
scattered through the stack, but there's not yet a documentation patch.


https://github.com/llvm/llvm-project/pull/133478
_______________________________________________
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

Reply via email to