cor3ntin wrote:
Thanks for working on this
I don't have time to do a full review yet, but this is going to need a lot more
tests
- Constant evaluation tests
- Preprocessor string concatenation
- Tests that we emit diagnostics for non-encodable strings
- Tests for wide strings ( It's not okay to assert on that, maybe a diagnostics
would be reasonable)
- Ensure that unevaluated strings are not converted (as in
`static_assert(false, "string")`, `[[deprecated("string")]]]`
- In C++, tests for `static_assert(false, string_view("string"))`
- Tests for diagnostics in printf strings
(This points to the need to sometimes convert strings from ebcdic to utf8 for
diagnostic purposes)
https://github.com/llvm/llvm-project/pull/138895
_______________________________________________
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
