================
@@ -246,18 +249,19 @@ class StringLiteralParser {
   StringLiteralEvalMethod EvalMethod;
 
 public:
-  StringLiteralParser(ArrayRef<Token> StringToks, Preprocessor &PP,
-                      StringLiteralEvalMethod StringMethod =
-                          StringLiteralEvalMethod::Evaluated);
+  StringLiteralParser(
+      ArrayRef<Token> StringToks, Preprocessor &PP,
+      StringLiteralEvalMethod StringMethod = 
StringLiteralEvalMethod::Evaluated,
+      ConversionAction Action = ToExecCharset);
----------------
cor3ntin wrote:

Why do we need Conversion at all.
I would expect that any ordinary, non-unevaluated literal would be encoded and 
the
`LiteralConverter` should be the same for all strings so it can live in 
`Preprocessor`

https://github.com/llvm/llvm-project/pull/138895
_______________________________________________
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

Reply via email to