https://github.com/mstorsjo approved this pull request.
LGTM, thanks - this looks reasonable to me, but I'd prefer to have an explicit ack from @jmorse still before merging. Minor nit, we could adjust the commit message (PR description), saying "even if that may be dllimported", instead of "is dllimported". If it has an explicit dllimport, iirc this issue doesn't hit at all - it's the "maybe dllimported" case which is problematic here. Longer term, as mentioned in #149639, we could consider just emitting this debug info in the object files that actually define the vtable, which could allow removing this restriction (to produce such debug info on COFF targets too). https://github.com/llvm/llvm-project/pull/150938 _______________________________________________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
